-
Notifications
You must be signed in to change notification settings - Fork 515
Add support for multiple identifiers in ignoreErrors configuration #4080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update parametersSchema.neon to support 'identifiers' array field - Modify IgnoredErrorHelper to expand identifiers array into separate rules - Update IgnoredError::stringifyPattern() to display multiple identifiers - Add comprehensive tests for identifiers array functionality - Update IgnoreErrorsTest to reflect new configuration entries Resolves #13015 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This pull request has been marked as ready for review. |
- Replace assertEmpty() with assertNoErrors() for clearer test intent - Replace assert() with assertInstanceOf() for proper PHPUnit assertions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Thank you! Please also send update to https://phpstan.org/user-guide/ignoring-errors with a brief mention of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some inconsistency
If both identifier and identifiers are used:
- identifier is read in stringifyPattern
- identifiers is read in IgnoredErrorHelper
Also maybe it shouldn't be allowed to have both identifier and identifiers ?
Or the behavior should be to merge both ?
I don't want to allow both in the same entry. stringifyPattern should be fixed I think? |
I agree, I opened #4143 |
Resolves phpstan/phpstan#13015
🤖 Generated with Claude Code